Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatically generated JPMS module descriptor #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add automatically generated JPMS module descriptor #24

wants to merge 1 commit into from

Conversation

ppkarwasz
Copy link

This PR adds configuration to bnd-maven-plugin to generate a module-info.class descriptor.

BND adds the module-info.class descriptor (and META-INF/MANIFEST.MF) directly into the generated JAR and works even on JDK 8 (cf. documentation).

The decompiled module descriptor is:

module [email protected] {
  requires java.base;
  exports com.neilalexander.jnacl.crypto;
  exports com.neilalexander.jnacl;
}

The lack of a stable module name is a (partial) blocker for zeromq/jeromq#591: users that require curve encryption can not (reliably) use JPMS.

@ppkarwasz
Add automatically generated JPMS module descriptor
d753e75 
Adds configuration to `bnd-maven-plugin` to generate a
`module-info.class` descriptor.
@ppkarwasz ppkarwasz mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ppkarwasz